Fix #5883: bind session/view push channels to their HTTP session - #5884
Merged
Conversation
The web socket handshake accepted any client presenting a known channel ID, so a leaked session or view scoped channel ID could be connected to from a foreign or absent HTTP session. Bind those channels to the HTTP session that registered them and refuse the handshake otherwise. Application scoped channels stay unbound by design. Also make the endpoint idle timeout and the maximum number of sessions per channel operator-configurable, both defaulting to the current behavior: - com.sun.faces.websocketEndpointIdleTimeout (default 0, no timeout) - com.sun.faces.websocketMaxSessionsPerChannel (default unbounded) Backport of omnifaces/omnifaces@d5cae24, ref GHSA-fp43-vj7g-pg92. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5883
The web socket handshake accepted any client presenting a known channel ID, so a leaked session or view scoped channel ID could be connected to from a foreign or absent HTTP session. Bind those channels to the HTTP session that registered them and refuse the handshake otherwise. Application scoped channels stay unbound by design.
Also make the endpoint idle timeout and the maximum number of sessions per channel operator-configurable, both defaulting to the current behavior:
com.sun.faces.websocketEndpointIdleTimeout(default 0, no timeout)com.sun.faces.websocketMaxSessionsPerChannel(default unbounded)Backport of omnifaces/omnifaces@d5cae24, ref GHSA-fp43-vj7g-pg92.